New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to copy only plain text to clipboard. #54155

Merged
merged 5 commits into from Sep 5, 2018

Conversation

Projects
None yet
4 participants
@mshoho
Member

mshoho commented Jul 12, 2018

An option to copy only plain text to clipboard, without the rich text version.

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Jul 12, 2018

Member

#21071 and #21820 look this request (duplicates of each other?)

Member

Tyriar commented Jul 12, 2018

#21071 and #21820 look this request (duplicates of each other?)

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Jul 12, 2018

Member

@rebornix maybe "editor.copyWithFormatting": true would be better as suggested in #21071 (comment) ?

Member

Tyriar commented Jul 12, 2018

@rebornix maybe "editor.copyWithFormatting": true would be better as suggested in #21071 (comment) ?

@mshoho

This comment has been minimized.

Show comment
Hide comment
@mshoho

mshoho Jul 17, 2018

Member

I can rename it, no problem. Just let me know.

Member

mshoho commented Jul 17, 2018

I can rename it, no problem. Just let me know.

@mshoho

This comment has been minimized.

Show comment
Hide comment
@mshoho
Member

mshoho commented Aug 16, 2018

Ping @rebornix.

@rsyring

This comment has been minimized.

Show comment
Hide comment
@rsyring

rsyring Aug 28, 2018

FWIW, in #21820 I'm arguing that the current behavior is a bug. Copy should, by default, only copy text and copy with syntax highlighting should not be the default behavior (as there is already a separate command for this). If that argument is accepted (big "if" :) ), then this issue could be closed.

rsyring commented Aug 28, 2018

FWIW, in #21820 I'm arguing that the current behavior is a bug. Copy should, by default, only copy text and copy with syntax highlighting should not be the default behavior (as there is already a separate command for this). If that argument is accepted (big "if" :) ), then this issue could be closed.

@mshoho

This comment has been minimized.

Show comment
Hide comment
@mshoho

mshoho Aug 28, 2018

Member

@rsyring I know people who need the highlighted copy, I suppose this thing is still needed, perhaps the default value should be inverted.

Member

mshoho commented Aug 28, 2018

@rsyring I know people who need the highlighted copy, I suppose this thing is still needed, perhaps the default value should be inverted.

@rebornix rebornix added this to the September 2018 milestone Sep 5, 2018

@rebornix

This comment has been minimized.

Show comment
Hide comment
@rebornix

rebornix Sep 5, 2018

Member

@mshoho thanks for your help, it looks great!

Member

rebornix commented Sep 5, 2018

@mshoho thanks for your help, it looks great!

@rebornix rebornix merged commit f67fd23 into Microsoft:master Sep 5, 2018

2 checks passed

VS Code #20180905.86 succeeded
Details
license/cla All CLA requirements met.
Details
@rsyring

This comment has been minimized.

Show comment
Hide comment
@rsyring

rsyring Sep 5, 2018

@mshoho thanks for putting some time into resolving this issue! :)

@rsyring I know people who need the highlighted copy, I suppose this thing is still needed, perhaps the default value should be inverted.

Yes, I think we should keep the feature.

I'm only saying that the default copy should not copy syntax highlighting. Let that be handled by the command that already exists. I'm not 100% sure what this PR is doing, so can't comment on the work-in-progress.

rsyring commented Sep 5, 2018

@mshoho thanks for putting some time into resolving this issue! :)

@rsyring I know people who need the highlighted copy, I suppose this thing is still needed, perhaps the default value should be inverted.

Yes, I think we should keep the feature.

I'm only saying that the default copy should not copy syntax highlighting. Let that be handled by the command that already exists. I'm not 100% sure what this PR is doing, so can't comment on the work-in-progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment