New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not auto-close when ending with open #55315

Merged
merged 3 commits into from Sep 5, 2018

Conversation

Projects
None yet
4 participants
@MattHardcastle
Contributor

MattHardcastle commented Jul 28, 2018

This pull request addresses #55314.

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Jul 28, 2018

CLA assistant check
All CLA requirements met.

msftclas commented Jul 28, 2018

CLA assistant check
All CLA requirements met.

@rebornix rebornix added this to the September 2018 milestone Sep 5, 2018

@rebornix rebornix merged commit 881258d into Microsoft:master Sep 5, 2018

2 checks passed

VS Code #20180905.77 succeeded with issues
Details
license/cla All CLA requirements met.
Details
@rebornix

This comment has been minimized.

Show comment
Hide comment
@rebornix

rebornix Sep 5, 2018

Member

@MattHardcastle thanks for your help, it's a really good catch!

Member

rebornix commented Sep 5, 2018

@MattHardcastle thanks for your help, it's a really good catch!

@dxf

This comment has been minimized.

Show comment
Hide comment
@dxf

dxf Oct 4, 2018

Thanks so much!!!

dxf commented Oct 4, 2018

Thanks so much!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment