Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable cycling of parameter hints #55354

Merged
merged 2 commits into from Aug 7, 2018

Conversation

@ozyx
Copy link
Contributor

commented Jul 30, 2018

Fixes #54726 by adding an option (default: false) to cycle through parameter hints instead of closing the autocomplete dialog when reaching the end of the list.

kapture 2018-07-30 at 1 38 59

I'm just beginning to get some experience with the VSCode codebase, so my choice of words in describing the action of this new option may not be ideal. Also, I put the option under "text editor" options-- if there is a better place for it, please let me know.

@jrieken jrieken added this to the August 2018 milestone Aug 6, 2018

@@ -684,6 +684,11 @@ const editorConfiguration: IConfigurationNode = {
'default': EDITOR_DEFAULTS.contribInfo.codeLens,
'description': nls.localize('codeLens', "Controls whether the editor shows CodeLens")
},
'editor.cycleParameterHints': {

This comment has been minimized.

Copy link
@jrieken

jrieken Aug 6, 2018

Member

Hm, maybe a better name which puts parameter hints first. My preference would be editor.parameterHints.cycle but that would require a refactoring of the existing editor.parameterHints setting, e.g. into editor.parameterHints.enabled.

This comment has been minimized.

Copy link
@ozyx

ozyx Aug 7, 2018

Author Contributor

Ok, I've refactored the settings as such in my latest commit.

@jrieken

This comment has been minimized.

Copy link
Member

commented Aug 7, 2018

lgtm. Thanks @ozyx!

@jrieken jrieken merged commit 1b8c51e into microsoft:master Aug 7, 2018

2 checks passed

VSTS: VS Code 20180807.4 succeeded with issues
Details
license/cla All CLA requirements met.
Details

@ozyx ozyx deleted the ozyx:cycle-parameterHints branch Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.