New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefill quick open #55752

Merged
merged 2 commits into from Oct 1, 2018

Conversation

Projects
None yet
4 participants
@Michel73
Contributor

Michel73 commented Aug 3, 2018

Implements #37932

@msftclas

This comment has been minimized.

msftclas commented Aug 3, 2018

CLA assistant check
All CLA requirements met.

@chrmarti chrmarti added this to the August 2018 milestone Aug 3, 2018

@chrmarti chrmarti modified the milestones: August 2018, September 2018 Aug 30, 2018

@Michel73

This comment has been minimized.

Contributor

Michel73 commented Sep 16, 2018

I moved all the logic according to the prefill-feature from quickOpenWidget to quickOpenController. Also the configuration aspects are handled in the quickOpenController without the need of disposing and recreating the QuickOpenWidget.
I also resolved the merge conflicts but github still asserts that they exists.

@Michel73 Michel73 force-pushed the Michel73:prefill-quick-open branch from 6f9cbf8 to bab1003 Sep 17, 2018

@Michel73

This comment has been minimized.

Contributor

Michel73 commented Sep 17, 2018

I had some problems synchronising with master repo. I had to rebase my branch. Now I did all the changes within a commit.

@chrmarti

This comment has been minimized.

Contributor

chrmarti commented Sep 24, 2018

Just came back from vacation. I will take a look probably next week since we are working on stabilizing for the next release this week.

@chrmarti chrmarti modified the milestones: September 2018, October 2018 Sep 24, 2018

@chrmarti chrmarti merged commit 9cd2bc0 into Microsoft:master Oct 1, 2018

2 checks passed

VS Code #20180917.28 succeeded with issues
Details
license/cla All CLA requirements met.
Details
@chrmarti

This comment has been minimized.

Contributor

chrmarti commented Oct 1, 2018

Merged, thanks @Michel73!

JimiC added a commit to JimiC/vscode that referenced this pull request Oct 5, 2018

Prefill quick open (Microsoft#55752)
Implemented prefilling quickOpen with last search input.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment