Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests about to check the improvements: ${}, $$, and $(shell ()). #55826

Merged
merged 1 commit into from Aug 6, 2018

Conversation

@fadeevab
Copy link
Contributor

commented Aug 4, 2018

Current issue: #55256, "[makefile] highlighting issues with variable definitions and shell commands".

Plus 1 shell test about parentheses from #25469

Alexandr Fadeev
Tests about to check the improvements: ${}, $$, and $(shell ()).
Current issue: #55256,
"[makefile] highlighting issues with variable definitions and shell commands".
@VictorMazilu

This comment has been minimized.

Copy link

commented Aug 4, 2018

😍

@aeschli aeschli merged commit 4911d7a into microsoft:master Aug 6, 2018

2 checks passed

VSTS: VS Code 20180804.5 succeeded with issues
Details
license/cla All CLA requirements met.
Details

@aeschli aeschli added this to the August 2018 milestone Aug 6, 2018

@aeschli

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

Thanks @fadeevab!

@fadeevab fadeevab deleted the fadeevab:make-test branch Dec 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.