Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the feedback form after clicking Submit a bug #55938

Merged
merged 4 commits into from Aug 22, 2018

Conversation

@itamark
Copy link
Contributor

commented Aug 7, 2018

Fixes #55713

@RMacfarlane RMacfarlane self-assigned this Aug 7, 2018

@ramya-rao-a ramya-rao-a requested a review from RMacfarlane Aug 7, 2018

.on('click', event => {
dom.EventHelper.stop(event);
if(!!this.requestFeatureLink){
shell.openExternal(this.requestFeatureLink);

This comment has been minimized.

Copy link
@RMacfarlane

RMacfarlane Aug 13, 2018

Contributor

This looks good!

I think it would be simpler to keep the 'href' as this.requestFeatureLink above, and then the on click could just have this.hide() and let the event bubble.

This comment has been minimized.

Copy link
@itamark

itamark Aug 14, 2018

Author Contributor

That's a really good point. I'll rework this tomorrow to use that approach.

Itamar Kestenbaum
@itamark

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2018

@RMacfarlane updated the PR with your idea of just letting the event bubble after hiding.

@RMacfarlane

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2018

Pushed one small change to remove an unused import. This looks good to me, thanks for your contribution!

@RMacfarlane RMacfarlane merged commit f2e49a2 into microsoft:master Aug 22, 2018

1 of 2 checks passed

VSTS: VS Code in progress
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.