New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override Ubuntu's default integrated terminal font options (#35901) #56429

Merged
merged 2 commits into from Sep 20, 2018

Conversation

Projects
None yet
4 participants
@andyli
Contributor

andyli commented Aug 15, 2018

As suggested in #56311 (comment).

@andyli

This comment has been minimized.

Show comment
Hide comment
@andyli

andyli Aug 27, 2018

Contributor

Is there any problem with this PR?

Contributor

andyli commented Aug 27, 2018

Is there any problem with this PR?

@Tyriar Tyriar added this to the September 2018 milestone Sep 11, 2018

@Tyriar

Tyriar approved these changes Sep 20, 2018

Thanks @andyli and sorry about the delay. It's unfortunate that this needs to happen at all. Hopefully I can get some time soon to work on a better fix I've had in mind for a while.

@Tyriar Tyriar merged commit 859367d into Microsoft:master Sep 20, 2018

1 of 2 checks passed

VS Code #20180920.9 failed
Details
license/cla All CLA requirements met.
Details
@jhpratt

This comment has been minimized.

Show comment
Hide comment
@jhpratt

jhpratt Oct 10, 2018

Minor "bug" arising from this: zsh's (and similar shells) powerline fonts no longer work by default.

jhpratt commented Oct 10, 2018

Minor "bug" arising from this: zsh's (and similar shells) powerline fonts no longer work by default.

@Tyriar Tyriar referenced this pull request Oct 11, 2018

Closed

Font rendering/scaling issue in Linux, integrated terminal #60409

4 of 4 tasks complete

Tyriar added a commit that referenced this pull request Oct 11, 2018

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Oct 11, 2018

Member

@jhpratt they should still work, you just need to set the font (try setting terminal.integrated.fontFamily instead of editor.fontFamily?)

Member

Tyriar commented Oct 11, 2018

@jhpratt they should still work, you just need to set the font (try setting terminal.integrated.fontFamily instead of editor.fontFamily?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment