Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #55723 - Show appropriate error message when extension gallery service is not accessible #56767

Merged
merged 1 commit into from Aug 21, 2018

Conversation

@jats22
Copy link
Contributor

commented Aug 19, 2018

This closes #55723 by replacing the await calls to normal promise call such that any errors are bubbled up.
@ramya-rao-a also I was wondering if a unit test for the scenario should be added?

@ramya-rao-a

This comment has been minimized.

Copy link
Member

commented Aug 20, 2018

@jats22 Thanks for the PR.

Unfortunately, we dont have unit tests around that area at the moment, but we definitely need some.
If you are interested, then then you can create a new test file say extensionsViews.test.ts in the folder vscode\src\vs\workbench\parts\extensions\test\electron-browser\ and add a test for the change you made.

Let me know if you plan to add any tests. If yes, then I'll wait for that else, merge this PR right away.

@ramya-rao-a ramya-rao-a added this to the August 2018 milestone Aug 20, 2018

@jats22

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2018

No problem. Unfortunately I am new to this project and I would rather wait to write a good test when I have a better understanding of it. So please merge it and I could contribute a well written unit test later. Thanks!

@ramya-rao-a ramya-rao-a merged commit c935654 into microsoft:master Aug 21, 2018

2 checks passed

VSTS: VS Code 20180819.2 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.