Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .eslintrc extension #57014

Merged
merged 1 commit into from Aug 23, 2018

Conversation

@ManoelLobo
Copy link
Contributor

commented Aug 22, 2018

Hello, mantainers! Thank you very much for this sensational app.

Overview

It is not a critical fix, but .eslintrc without extension is deprecated (https://eslint.org/docs/user-guide/configuring#configuration-file-formats).

Changes

Add .json extension to .eslintrc

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

Thanks! 🍻

@joaomoreno joaomoreno merged commit 6fa9cb7 into microsoft:master Aug 23, 2018

2 checks passed

VSTS: VS Code 20180822.71 succeeded
Details
license/cla All CLA requirements met.

@joaomoreno joaomoreno added this to the August 2018 milestone Aug 23, 2018

@ManoelLobo ManoelLobo deleted the ManoelLobo:pr/eslintrc-extension branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.