Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selectAllMatches command in column selection mode. #5715

Merged
merged 2 commits into from May 4, 2016

Conversation

Projects
None yet
8 participants
@Inori
Copy link
Contributor

commented Apr 24, 2016

vs_ml
Operation flow:

  1. Ctrl+F --> Open find widegt.
  2. Alt+R --> Turn on regex mode.
  3. Input search text --> Regex text or normal text.
  4. Alt+Enter --> Select all matches.
  5. Left arrow --> Ajust cursors.(Ignore this step if you don't want to edit the selected text.)
  6. Edit text --> Do what you want.(Ignore this step if you don't want to edit the selected text.)
  7. Shift+Home --> Select modified text.(Ignore this step if you don't want to edit the selected text.)
  8. Ctrl+C --> Copy selected text.
  9. Ctrl+N --> Open a new tab.
    10 .Ctrl+V --> Paste.

Compared to sublime:
sb_ml

@mention-bot

This comment has been minimized.

Copy link

commented Apr 24, 2016

By analyzing the blame information on this pull request, we identified @ajkerrigan and @alexandrudima to be potential reviewers

@msftclas

This comment has been minimized.

Copy link

commented Apr 24, 2016

Hi @Inori, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas

This comment has been minimized.

Copy link

commented Apr 24, 2016

@Inori, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@msftclas msftclas added cla-signed and removed cla-required labels Apr 24, 2016

@Inori

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2016

@alexandrudima alexandrudima added this to the May 2016 milestone Apr 26, 2016

@alexandrudima alexandrudima merged commit aeb155d into microsoft:master May 4, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

alexandrudima added a commit that referenced this pull request May 4, 2016

Merge pull request #5715 from Inori/select_all_find_matches
Add selectAllMatches command in find widget.
@alexandrudima

This comment has been minimized.

Copy link
Member

commented May 4, 2016

@Inori Thank you, nice job! ❤️

@pcarrier

This comment has been minimized.

Copy link

commented May 11, 2016

Do we know when this will land? It's a killer feature for me and I was disappointed it's not in 1.1.0.

@taoqf

This comment has been minimized.

Copy link

commented Jun 7, 2016

maybe we need 'alt+f3' to select all the same words when some are selected.

@greatbody

This comment has been minimized.

Copy link

commented Jun 8, 2016

just like "ctrl+d" in sublime

public selectAllMatches(): boolean {
if (this._model) {
this._model.selectAllMatches();
this.closeFindWidget();

This comment has been minimized.

Copy link
@yisibl

yisibl Jun 11, 2016

Contributor
this.closeFindWidget();

Why is it removed in the latest code(in master branch)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.