New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GDPR annotation for typescript-language-features/languageserviceerrorresponse #57182

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
2 participants
@amcasey
Member

amcasey commented Aug 24, 2018

I'm not sure how to validate the comment itself, but I believe the classifications are correct.

"languageServiceErrorResponse" : {
"command" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"message" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
"stack" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },

This comment has been minimized.

@mjbvz

mjbvz Aug 27, 2018

Contributor

I believe that the stack will include paths if a user is using the workspace version of typescript

@mjbvz

mjbvz Aug 27, 2018

Contributor

I believe that the stack will include paths if a user is using the workspace version of typescript

This comment has been minimized.

@amcasey

amcasey Aug 27, 2018

Member

I understand that the classification "CallstackOrException" covers that.

@amcasey

amcasey Aug 27, 2018

Member

I understand that the classification "CallstackOrException" covers that.

@mjbvz mjbvz added this to the September 2018 milestone Sep 4, 2018

@mjbvz mjbvz merged commit cd7c7c5 into Microsoft:master Sep 4, 2018

2 checks passed

VSTS: VS Code 20180824.91 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment