New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix promise polyfill, chaining promises works #57723

Merged
merged 1 commit into from Sep 3, 2018

Conversation

Projects
None yet
3 participants
@blutorange
Contributor

blutorange commented Sep 1, 2018

Possible solution for #57722

The callbacks in WinJSPromise.then (like native Promises) can return another promise instead of the next value. This can be used to allow chaining promises while stil having them work asynchronously.

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Sep 1, 2018

CLA assistant check
All CLA requirements met.

msftclas commented Sep 1, 2018

CLA assistant check
All CLA requirements met.

@jrieken

This comment has been minimized.

Show comment
Hide comment
@jrieken

jrieken Sep 3, 2018

Member

lgtm. Thanks.

Member

jrieken commented Sep 3, 2018

lgtm. Thanks.

@jrieken

jrieken approved these changes Sep 3, 2018

@jrieken jrieken added this to the September 2018 milestone Sep 3, 2018

@jrieken jrieken merged commit b58abdc into Microsoft:master Sep 3, 2018

2 checks passed

VS Code #20180901.1 succeeded with issues
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment