New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] Add command to create branch from specific ref #59078

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@guywald1
Copy link
Contributor

guywald1 commented Sep 21, 2018

Closes #55732.

@@ -1932,7 +1944,7 @@ export class CommandCenter {
return Promise.resolve();
}

return Promise.resolve(method.apply(this, [repository, ...args]));
return Promise.resolve(method.apply(this, [repository, ...args.slice(1)]));

This comment has been minimized.

@guywald1

guywald1 Sep 21, 2018

Author Contributor

Same change as in #58963.
Allows to pass multiple variables in case of repository being set to true in the command options.
Would appreciate a sanity check by someone to see that it shouldn't break anything.

This comment has been minimized.

@joaomoreno

joaomoreno Jan 4, 2019

Member

Reverted this, since it is unnecessary after the refactoring.

@guywald1 guywald1 force-pushed the guywald1:git-create-branch-off-remote branch from 215db9b to 902603d Sep 21, 2018

@joaomoreno joaomoreno added the git label Sep 24, 2018

@joaomoreno joaomoreno added this to the Backlog milestone Sep 24, 2018

@guywald1 guywald1 force-pushed the guywald1:git-create-branch-off-remote branch from 902603d to 3c220b8 Oct 4, 2018

@guywald1 guywald1 force-pushed the guywald1:git-create-branch-off-remote branch from 3c220b8 to ad6660d Oct 4, 2018

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Jan 4, 2019

Thanks! 🎆

I've refactored it a bit and simply added it to the Create Branch... command and always show a HEAD option as the default, such that the user can just press Enter to continue creating a branch in the current HEAD.

@joaomoreno joaomoreno merged commit ad6660d into Microsoft:master Jan 4, 2019

2 checks passed

VS Code #20181004.27 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment