New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Git:Fetch (prune) #59735

Merged
merged 3 commits into from Nov 20, 2018

Conversation

Projects
None yet
4 participants
@rscott
Copy link
Contributor

rscott commented Oct 1, 2018

My attempt at fixing #59693

@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 1, 2018

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno added the git label Oct 1, 2018

@joaomoreno joaomoreno added this to the October 2018 milestone Oct 1, 2018

"command": "git.fetchPrune",
"title": "%command.fetchPrune%",
"category": "Git"
},
{
"command": "git.fetchAll",
"title": "%command.fetchAll%",

This comment has been minimized.

@oneslash

oneslash Oct 2, 2018

Contributor

also don't forget to add condition in menus.menus.commandPalette

This comment has been minimized.

@rscott

rscott Oct 3, 2018

Contributor

Thanks @oneslash, I definitely missed this

@@ -1172,6 +1172,11 @@ export class Repository {
args.push('--all');
}

if (options.prune) {
args.push('-p');

This comment has been minimized.

@oneslash

oneslash Oct 2, 2018

Contributor

I believe more understandable would be to use full argument name --prune

This comment has been minimized.

@rscott

rscott Oct 3, 2018

Contributor

Agree, just habit of typing the short form in the CLI 😄

@joaomoreno joaomoreno modified the milestones: October 2018, November 2018 Nov 6, 2018

@joaomoreno joaomoreno merged commit 4b4fa8c into Microsoft:master Nov 20, 2018

1 of 2 checks passed

VS Code #20181003.1 failed
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 20, 2018

Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment