New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable mojave dark mode support #59742

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Contributor

MarshallOfSound commented Oct 1, 2018

Electron is not built on the 10.14 SDK so we need to set a special Info.plist key to tell macOS we support dark mode.

Closes #59421
Closes #59283
Closes #54838 (maybe, the line looks a little different but I think it's how mojave dark mode windows look)

Blocked by: joaomoreno/gulp-atom-electron#51

@bpasero bpasero self-assigned this Oct 1, 2018

@bpasero bpasero added this to the October 2018 milestone Oct 1, 2018

@bpasero bpasero merged commit 8ee605e into Microsoft:master Oct 1, 2018

1 of 2 checks passed

VS Code #20181001.68 failed
Details
license/cla All CLA requirements met.
@bpasero

This comment has been minimized.

Member

bpasero commented Oct 1, 2018

@MarshallOfSound

This comment has been minimized.

Contributor

MarshallOfSound commented Oct 1, 2018

@bpasero Works perfectly 👍

@bgarrant

This comment has been minimized.

bgarrant commented Oct 2, 2018

When can we get this Mojave Dark Mode support for VS Code?

@bgarrant

This comment has been minimized.

bgarrant commented Oct 2, 2018

@bpasero Is this expected out soon for VS Code? Dark Mode is so nice on the eyes

@MarshallOfSound MarshallOfSound deleted the MarshallOfSound:feat/mojave-dark-mode branch Oct 2, 2018

JimiC added a commit to JimiC/vscode that referenced this pull request Oct 5, 2018

@warpdesign

This comment has been minimized.

Contributor

warpdesign commented Oct 8, 2018

Is it fixed in insider builds? I still have the problem (even if macOS hasn't dark mode enabled, I see a gray line on top of VSCode).

@bpasero

This comment has been minimized.

Member

bpasero commented Oct 8, 2018

Not yet out (this week), but you can use Electron 3.0.x builds where this fix is in:

@warpdesign

This comment has been minimized.

Contributor

warpdesign commented Oct 8, 2018

@bpasero unfortunately it doesn't fix the problem:

image

@bpasero

This comment has been minimized.

Member

bpasero commented Oct 8, 2018

@warpdesign those builds are old, you should get an update and then its fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment