Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
remove extra margins on completion hovers with markdown #59786
We need those margins for docs that have multiple paragraphs.
Below is one such case:
Below is the same case with the changes in this PR
Set sticky to
true. Then in the local instance of VS Code, run Help -> Toggle Developer Tools -> Elements`
So, we have to
- Remove the margin top only on the first
<p>, and margin bottom on the last
- Add margin-bottom to the element above the
referenced this pull request
Oct 8, 2018
Well... It was harder than it seemed
Now I think it working as expected:
header + one paragraph:
header + two paragraphs:
header + more than two paragraphs
no header, no markdown
no header, markdown
I was forced to add a class when rendering the widget in order to be able to remove the header padding when the docs section is empty. I think it shouldn't be a problem.
Thanks for your help!