New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #57910 - Add setting for auto fetch timeout #59988

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@w9jds
Copy link
Contributor

w9jds commented Oct 4, 2018

Finishes the race condition when either setting is changed, and then if it wasn’t disabled creates a new timeout using the new value (instead of waiting for it to go through the loop again to update).

Fix #57910 - Add setting for auto fetch timeout
Finishes the race condition when either setting is changed, and then if it wasn’t disabled creates a new timeout using the new value (instead of waiting for it to go through the loop again to update).
@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 4, 2018

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno added the git label Oct 9, 2018

@joaomoreno joaomoreno added this to the Backlog milestone Oct 9, 2018

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Jan 4, 2019

Changed the unit to seconds instead of minutes. Also cleaned up all that complexity of resetting the machine when that value changes. It's more than OK to just wait until the next auto fetch gets triggered to trigger a new one with the new delay.

Thanks! 🎆

@joaomoreno joaomoreno merged commit 7761add into Microsoft:master Jan 4, 2019

2 checks passed

VS Code #20181004.55 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment