Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed #59395 - Emmet Syntax Profiles tag_nl produces no extra space #60108
The tests seem to be failing. Can you take a look at that?
To run the tests locally, run
scripts\test-integration.bat on Windows or
./scripts/test-integration.sh on Linux/Mac
It would also do us good to add a test case to cover this scenario.
wrapWithAbbreviation.test.ts would be the file to update.
My apologies, I should have cleared some things previously.
The new emmet modules that we use dont use the same
syntaxProfile settings as documented in https://docs.emmet.io/customization/syntax-profiles/
The new emmet modules follow the profile as defined in https://github.com/emmetio/output-profile/blob/1a7571e78da9d7bf056289b3396dbb0bcc45c435/types.d.ts#L1
To support backward compatibility in VS Code, we support both in the settings. I convert the old profile to a new one using a helper
So now coming to the current issue. You can just add
expandOptions['format'] === true to the
if condition and that should be enough.
https://github.com/Microsoft/vscode/blob/release/1.28/extensions/emmet/src/test/abbreviationAction.test.ts#L441 is an example where I changed the config for the