New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to allow to disable Replace Preview #60153

Merged
merged 3 commits into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@ToothlessGear
Contributor

ToothlessGear commented Oct 8, 2018

Introduces a new settings option "search.useReplacePreview" which
allows you to disable "Replace Preview" during a Search/Replace.

Closes #60027

Add setting to allow to disable Replace Preview
Introduces a new settings option "search.useReplacePreview" which
allows you to disable "Replace Preview" during a Search/Replace.

Closes #60027

@roblourens roblourens added this to the October 2018 milestone Oct 8, 2018

@ToothlessGear

This comment has been minimized.

Contributor

ToothlessGear commented Oct 8, 2018

Hi,

regarding https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/search/browser/searchActions.ts#L581.
I checked this, but I am not sure how to trigger the alternative path in the condition. The condition seems to be always true and therefore never opens Replace Preview.

@roblourens

This comment has been minimized.

Member

roblourens commented Oct 8, 2018

I see it when clicking the replace button in a file with a bunch of matches.

@ToothlessGear

This comment has been minimized.

Contributor

ToothlessGear commented Oct 9, 2018

I think I got it now, thanks for taking the time to review.

@roblourens

Thanks for the PR!

@roblourens roblourens merged commit def5463 into Microsoft:master Oct 9, 2018

2 checks passed

VS Code #20181008.74 succeeded with issues
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment