New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #58159 by triggering a layout refresh to work around xtermjs bug… #60221

Merged
merged 2 commits into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@josephduchesne
Copy link
Contributor

josephduchesne commented Oct 9, 2018

Fixed #58159 by triggering a layout refresh to work around xtermjs bug based on Git-Lior's tip.

This might also help with #59000, but I wasn't sure exactly how to reproduce that.

I kept the same HACK warning as the other edit in hopes that when one gets removed, both can be.

Prior to applying this I could reproduce the issue a good percentage of the time, but afterwards I was unable to reproduce this issue. I tested further by switching back to master and I could reproduce the issue again.

@Tyriar

This comment has been minimized.

Copy link
Member

Tyriar commented Dec 13, 2018

Thanks @josephduchesne, this works really great! Sorry about the delay, I was on vacation all November 🌴

@Tyriar Tyriar added this to the December 2018 milestone Dec 13, 2018

@Tyriar Tyriar merged commit dfc984f into Microsoft:master Dec 13, 2018

1 of 2 checks passed

VS Code in progress
Details
license/cla All CLA requirements met.
@Tyriar

This comment has been minimized.

Copy link
Member

Tyriar commented Dec 13, 2018

Also it looks like it does fix #59000 👌

@josephduchesne josephduchesne deleted the josephduchesne:fixes-58159-terminal-vanishing-on-font-resize branch Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment