New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #46816 #60404

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@greybax
Copy link
Contributor

greybax commented Oct 9, 2018

No description provided.

greybax

@chrmarti chrmarti added this to the October 2018 milestone Oct 12, 2018

@chrmarti

This comment has been minimized.

Copy link
Contributor

chrmarti commented Oct 12, 2018

Thanks for your contribution! Using Solarize Light suggests that the background should be set on .welcomePageContainer and that the default should be null, so the regular editor background is used:

image

Could you update the PR with these changes?

@chrmarti chrmarti removed this from the October 2018 milestone Oct 24, 2018

@greybax

This comment has been minimized.

Copy link
Contributor

greybax commented Oct 26, 2018

yes, sure. Will do now

@chrmarti chrmarti modified the milestones: October 2018, November 2018 Oct 29, 2018

@chrmarti chrmarti merged commit 6eb24fb into Microsoft:master Nov 6, 2018

2 checks passed

VS Code #20181026.30 succeeded
Details
license/cla All CLA requirements met.
@chrmarti

This comment has been minimized.

Copy link
Contributor

chrmarti commented Nov 6, 2018

Thanks @greybax !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment