New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updates to be completely disabled or manual, as well as automatic #60973

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@krider2010
Copy link
Contributor

krider2010 commented Oct 15, 2018

Also updated log messages about why updates are disabled having seen a few issues via google (when researching related to this) that cannot diagnose why updates are not working or not visible.

update-channel

This addresses #12817, but I'm not sure how to automate testing this, or what more I can. Any direction as to how I can do so would be great. I cannot comment on that issue directly to ask for help as it's locked to contributors at the moment.

I've manually tested setting values in the update service to ensure the log (--verbose is great ;) ) and UI show what is expected.

Allow updates to be completely disabled or manual, as well as automatic
Also updated log messages about why updates are disabled having seen a few issues via google (when researching related to this) that cannot diagnose why updates are not working or not visible.
@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 15, 2018

CLA assistant check
All CLA requirements met.

@krider2010

This comment has been minimized.

Copy link
Contributor Author

krider2010 commented Oct 15, 2018

Related to my PR comments about testing, I'm also not sure what to do about these test failures as they seem to be whitespace and timeout related 😢

@joaomoreno joaomoreno added this to the Backlog milestone Oct 15, 2018

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Jan 4, 2019

Thanks! 🎆

@joaomoreno joaomoreno merged commit 30bee69 into Microsoft:master Jan 4, 2019

1 of 2 checks passed

VS Code #20181015.54 failed
Details
license/cla All CLA requirements met.
Details

@krider2010 krider2010 deleted the krider2010:manual-update-option branch Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment