New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#61410 Add keybinding to "Find in Folder" action #61526

Merged
merged 3 commits into from Dec 22, 2018

Conversation

Projects
None yet
4 participants
@maxbarnas
Copy link
Contributor

maxbarnas commented Oct 22, 2018

Resolves #61410

Decided to go with proposed cmd+alt+f / ctrl+alt+f

I left the handler in search.contibutions.ts because of import linting rules on workbench/parts/*/browser/* files. Happy to fix that if pointed how.

@Tyriar

This comment has been minimized.

Copy link
Member

Tyriar commented Oct 22, 2018

@roblourens I'm not sure we're meant to use ctrl+alt+ as default keybindings?

@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 22, 2018

CLA assistant check
All CLA requirements met.

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Oct 22, 2018

How about shift+alt+f on windows?

@maxbarnas

This comment has been minimized.

Copy link
Contributor Author

maxbarnas commented Oct 22, 2018

How about shift+alt+f on windows?

Works fine when having selected a folder. But fires code formatting when focused in editor and opens File menu when focused on a file (not folder) in Side Explorer. None of those are happening with Ctrl+Alt+f.

Still, I might be missing bigger picture here therefore I can lean towards your suggestion.

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Oct 23, 2018

So I filed #61644 for the File menu opening when alt+shift+f is pressed, because that seems wrong. I like that keybinding so let's wait just a bit to see where that goes.

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Nov 1, 2018

Ok that other issue has been fixed, I think alt+shift+f is a good shortcut. But it's too late for the October release. You can update the PR anytime and I'll merge it next week for the November release.

@maxbarnas maxbarnas force-pushed the maxbarnas:feature/gh-61410-search-in-folder-keybinding branch from c83aa63 to 4e80aaa Nov 1, 2018

@maxbarnas

This comment has been minimized.

Copy link
Contributor Author

maxbarnas commented Nov 1, 2018

I've changed the key binding but some pipelines failed for (apparently) no good reason. Is there a way to rerun them?

Edit: Nevermind, I rebased onto updated master and pipelines passed fine

@maxbarnas maxbarnas force-pushed the maxbarnas:feature/gh-61410-search-in-folder-keybinding branch from 06cd9f9 to 6d28eaf Nov 1, 2018

@roblourens roblourens added this to the November 2018 milestone Nov 1, 2018

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Dec 10, 2018

Sorry, I forgot about this PR. Taking a look now.

@maxbarnas maxbarnas force-pushed the maxbarnas:feature/gh-61410-search-in-folder-keybinding branch from d1a45b8 to 8dc19f2 Dec 22, 2018

@roblourens roblourens merged commit 2316dd6 into Microsoft:master Dec 22, 2018

2 checks passed

VS Code #20181222.8 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment