New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Markdown Preview incorrectly encodes a link #61530

Merged
merged 1 commit into from Oct 22, 2018

Conversation

Projects
None yet
2 participants
@sankt-petersbug
Contributor

sankt-petersbug commented Oct 22, 2018

For known external scheme, the customized normalizeLink method use vscode.Uri to parse and create
the string representation of the link before caling the original normalizeLink method.
The toString method of vscode.Uri encodes the result by default, and this is unecessary since encoding
is handled by the original normalizeLink method.

Calls toString method with skipEncoding option.

Resolves: #60525

Fix Markdown Preview incorrectly encodes a link
For known external scheme, the customized normalizeLink method use vscode.Uri to parse and create
the string representation of the link before caling the original normalizeLink method.
The toString method of vscode.Uri encodes the result by default, and this is unecessary since encoding
is handled by the original normalizeLink method.

Calls toString method with skipEncoding option.

Resolves: #60525

@mjbvz mjbvz added this to the October 2018 milestone Oct 22, 2018

@mjbvz mjbvz merged commit f2653c0 into Microsoft:master Oct 22, 2018

2 checks passed

VS Code #20181022.60 succeeded
Details
license/cla All CLA requirements met.
@mjbvz

This comment has been minimized.

Contributor

mjbvz commented Oct 22, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment