New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiline breakpoint widget - implementing #56521 #61859

Merged
merged 2 commits into from Oct 29, 2018

Conversation

Projects
None yet
4 participants
@YisraelV
Contributor

YisraelV commented Oct 26, 2018

No description provided.

@msftclas

This comment has been minimized.

msftclas commented Oct 26, 2018

CLA assistant check
All CLA requirements met.

@weinand

This comment has been minimized.

Member

weinand commented Oct 26, 2018

Thanks for the PR.
What problem is this PR trying to solve?

@isidorn isidorn self-assigned this Oct 26, 2018

@isidorn

This comment has been minimized.

Contributor

isidorn commented Oct 26, 2018

@weinand here's the issue for the PR #56521

@@ -127,6 +127,16 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi
}
}
public show(rangeOrPos: IRange | IPosition, _: number) {

This comment has been minimized.

@isidorn

isidorn Oct 26, 2018

Contributor

Use a proper name, not _ even though it is not used

@@ -127,6 +127,16 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi
}
}
public show(rangeOrPos: IRange | IPosition, _: number) {
let lineNum = this.input.getModel().getLineCount();

This comment has been minimized.

@isidorn

isidorn Oct 26, 2018

Contributor

I prefer const to let if it will not be mutated, so can you please use const

@@ -144,6 +154,9 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi
this.createBreakpointInput(dom.append(container, $('.inputContainer')));
this.input.getModel().setValue(this.getInputValue(this.breakpoint));
this.input.getModel().onDidChangeContent(() => {

This comment has been minimized.

@isidorn

isidorn Oct 26, 2018

Contributor

This is a listener, add it to the this.toDispose

}
public fitHeightToContent() {
let lineNum = this.input.getModel().getLineCount();

This comment has been minimized.

@isidorn

isidorn Oct 26, 2018

Contributor

Same here, please use const

@isidorn

This comment has been minimized.

Contributor

isidorn commented Oct 26, 2018

@YisraelV great work, I really like it.
I commented directly in the code, so once you address that we can merge this in.

I checked for the css change, and I can no longer reproduce the original bug so we are good there. You do not have to worry about that.

@isidorn isidorn added the debug label Oct 26, 2018

@isidorn isidorn added this to the October 2018 milestone Oct 26, 2018

@YisraelV YisraelV force-pushed the YisraelV:master branch from a49a330 to 5342bf2 Oct 28, 2018

@YisraelV

This comment has been minimized.

Contributor

YisraelV commented Oct 28, 2018

@isidorn that's very nice to hear thank you very much.

I made the requested changes. Would you like me to squash my two commits into 1?

@isidorn

This comment has been minimized.

Contributor

isidorn commented Oct 29, 2018

@YisraelV no need for squashing, merging it in. Thanks a lot!

@isidorn isidorn merged commit d71f741 into Microsoft:master Oct 29, 2018

1 of 2 checks passed

VS Code #20181028.1 failed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment