New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'overwrite' to 'override' in setting screens #61926

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
5 participants
@philiparola
Copy link
Contributor

philiparola commented Oct 27, 2018

On screens for workplace, folder, and other settings, there are prompts that inform the user of the hierarchy of the settings.
Overwrite implies that the setting will be changed rather than superseded.

Change 'overwrite' to 'override' in setting screens
Overwrite implies that the setting will be changed rather than superseded.
@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 27, 2018

CLA assistant check
All CLA requirements met.

@jcs090218
Copy link

jcs090218 left a comment

I think overwrite will be the better word choice than the word override in this case.

@philiparola

This comment has been minimized.

Copy link
Contributor

philiparola commented Nov 8, 2018

Overwrite means that changing the Workspace Settings will permanently change the User Settings. Override means that the User Setting will remain the same, but ignored for this Workspace.

The difference is subtle, but important.

@sandy081 sandy081 added this to the November 2018 milestone Nov 12, 2018

@sandy081 sandy081 merged commit 3a08ae6 into Microsoft:master Nov 12, 2018

1 of 2 checks passed

VS Code #20181027.8 failed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment