New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align badge theming with the GUI badge #61965

Merged
merged 2 commits into from Oct 29, 2018

Conversation

Projects
None yet
2 participants
@usernamehw
Contributor

usernamehw commented Oct 27, 2018

Fixes #61959

@usernamehw

This comment has been minimized.

Contributor

usernamehw commented Oct 27, 2018

Not sure if no-results class should be deleted from the element.

@roblourens

This comment has been minimized.

Member

roblourens commented Oct 28, 2018

Looks great but yeah the no-results class can be removed, please do that too

@roblourens

Thanks!

@roblourens roblourens merged commit 4626bc0 into Microsoft:master Oct 29, 2018

2 checks passed

VS Code #20181028.19 succeeded
Details
license/cla All CLA requirements met.
Details

@usernamehw usernamehw deleted the usernamehw:align-badge-color branch Oct 29, 2018

@roblourens roblourens added this to the October 2018 milestone Nov 2, 2018

@usernamehw

This comment has been minimized.

Contributor

usernamehw commented Nov 5, 2018

@roblourens, there is now an unused parameter count (I didn't see it)

public showMessage(message: string, count: number): void {
// Avoid setting the aria-label unnecessarily, the screenreader will read the count every time it's set, since it's aria-live:assertive. #50968
if (this.countElement && message !== this.countElement.textContent) {

@roblourens

This comment has been minimized.

Member

roblourens commented Nov 5, 2018

Thanks, I just cleaned it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment