New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an entry to the search history when the search is triggered by an option change #61993

Merged
merged 4 commits into from Nov 12, 2018

Conversation

Projects
None yet
3 participants
@iBlackShadow
Copy link
Contributor

iBlackShadow commented Oct 28, 2018

fixes #61346

Add an entry to the search history when the search
was triggered by an option change
@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Oct 29, 2018

This looks great but it makes me realize that we have the same problem in another case - when the user presses enter in the "files to include/exclude" box, it also doesn't save the history. Maybe we should call addToHistory from onQueryChanged?

@iBlackShadow

This comment has been minimized.

Copy link
Contributor

iBlackShadow commented Oct 30, 2018

that might be the best solution because that way we can be sure that the history is saved every time a search is done.

i will give it a try to see how it works.

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Nov 8, 2018

Are you still looking at this @iBlackShadow?

@iBlackShadow

This comment has been minimized.

Copy link
Contributor

iBlackShadow commented Nov 8, 2018

Yeah, i have been a little busy but i want to fix this this weekend.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 11, 2018

CLA assistant check
All CLA requirements met.

iBlackShadow and others added some commits Nov 11, 2018

@roblourens roblourens merged commit fedb338 into Microsoft:master Nov 12, 2018

1 check was pending

VS Code in progress
Details

@roblourens roblourens added this to the November 2018 milestone Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment