New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental fallthrough in snapshot loader #62294

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
3 participants
@xfix
Copy link
Contributor

xfix commented Oct 31, 2018

That said, I'm literally not sure how this code works. Maybe the correct fix is to remove this file instead?

@xfix xfix force-pushed the xfix:patch-3 branch from 8fd0c64 to 46917c5 Oct 31, 2018

@xfix xfix force-pushed the xfix:patch-3 branch from 46917c5 to 0ea3723 Oct 31, 2018

@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 31, 2018

CLA assistant check
All CLA requirements met.

@kieferrm kieferrm requested a review from jrieken Oct 31, 2018

@jrieken jrieken added this to the November 2018 milestone Nov 2, 2018

@jrieken

This comment has been minimized.

Copy link
Member

jrieken commented Nov 2, 2018

lgtm

@jrieken jrieken merged commit ef872db into Microsoft:master Nov 2, 2018

2 checks passed

VS Code #20181031.44 succeeded
Details
license/cla All CLA requirements met.
Details
@jrieken

This comment has been minimized.

Copy link
Member

jrieken commented Nov 2, 2018

Maybe the correct fix is to remove this file instead?

Yeah, currently that code isn't used but we have plan to bring it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment