New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #62112 - merge overlapping delete operations #62667

Merged
merged 2 commits into from Nov 10, 2018

Conversation

Projects
None yet
2 participants
@YisraelV
Copy link
Contributor

YisraelV commented Nov 6, 2018

There are more details at the issue #62112 page

@YisraelV

This comment has been minimized.

Copy link
Contributor

YisraelV commented Nov 7, 2018

I could write unit tests for the function _getLinesToRemove if that's advisable. If I do I think it would be better for the signature to be _getLinesToRemove(selections: Selection[]) so that we don't have to mock the editor.

Please tell me if I should do that and if yes if I should add it to this pull request.

@alexandrudima alexandrudima added this to the November 2018 milestone Nov 10, 2018

@alexandrudima alexandrudima merged commit 1127800 into Microsoft:master Nov 10, 2018

1 of 2 checks passed

VS Code in progress
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment