New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #62785 empty lines in debug console copyAll #62823

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
2 participants
@leonm1
Copy link
Contributor

leonm1 commented Nov 9, 2018

Example outputs

Fixes #62785 - Copy All action in debug terminal inserts extra lines in between output

Prior to change


C:\Program Files\nodejs\node.exe --inspect-brk=32511 binSearch.js 
Debugger listening on ws://127.0.0.1:32511/6309b5be-dae5-424f-9065-ba2b8af0a4d0

Debugger attached.

c:\Users\matth\Desktop\binSearch.js:5

const binarySearch = (tar, nums) => {

                     ^



RangeError: Maximum call stack size exceeded

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:5:22)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

Waiting for the debugger to disconnect...

RangeError: Maximum call stack size exceeded
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:5:22)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

After change


C:\Program Files\nodejs\node.exe --inspect-brk=3546 binSearch.js
Debugger listening on ws://127.0.0.1:3546/f4a816f9-e0bb-43f9-be24-7e36e30ee971
Debugger attached.
c:\Users\matth\Desktop\binSearch.js:5
const binarySearch = (tar, nums) => {
                     ^

RangeError: Maximum call stack size exceeded
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:5:22)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
Waiting for the debugger to disconnect...
RangeError: Maximum call stack size exceeded
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:5:22)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

Tested with master branch on both Windows 10 and ArchLinux.

@isidorn isidorn added this to the November 2018 milestone Nov 9, 2018

@isidorn isidorn added the debug label Nov 9, 2018

@isidorn isidorn merged commit f637774 into Microsoft:master Nov 9, 2018

1 of 2 checks passed

VS Code #20181109.6 failed
Details
license/cla All CLA requirements met.
@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Nov 9, 2018

@leonm1 thanks a lot for your nice PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment