New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict null checks for keyboardMapperTestUtils #63027

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
4 participants
@Logerfo
Copy link
Contributor

Logerfo commented Nov 13, 2018

This is my first contribution to this repo, I'm keeping it short to make sure I'm on the right path.
#60565
@mjbvz

@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 13, 2018

CLA assistant check
All CLA requirements met.

@Logerfo

This comment has been minimized.

Copy link
Contributor

Logerfo commented Nov 13, 2018

I don't think that the build failure is my fault. I got some errors even before making any changes, so I ignored them.

@alexandrudima

This comment has been minimized.

Copy link
Member

alexandrudima commented Nov 13, 2018

LGTM

@alexandrudima alexandrudima merged commit 3ad0008 into Microsoft:master Nov 13, 2018

1 of 2 checks passed

VS Code in progress
Details
license/cla All CLA requirements met.
Details

@alexandrudima alexandrudima added this to the November 2018 milestone Nov 13, 2018

@Logerfo

This comment has been minimized.

Copy link
Contributor

Logerfo commented Nov 13, 2018

@mjbvz don't forget to mark it as done at #60565 (comment), preventing other people to do the same work ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment