New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Improvements to clear button behavior #63082

Merged
merged 4 commits into from Dec 10, 2018

Conversation

Projects
None yet
6 participants
@aechan
Copy link
Contributor

aechan commented Nov 14, 2018

Issue: #62952

Made a few improvements to the behavior of the search clear button based off the suggestions in the above issue.

The clear button now:

  • Enables after any input to any input box in the search form
  • Disables after input is cleared from all input boxes in the search form
  • Clears all input from the search form now including the include and exclude filters
Issue #62952: Disabled clear button only when all fields are cleared …
…and enabled clear button after any input in search form.
@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 14, 2018

CLA assistant check
All CLA requirements met.

@roblourens roblourens self-assigned this Nov 14, 2018

@gowtham9494

This comment has been minimized.

Copy link

gowtham9494 commented Nov 23, 2018

great

@roblourens roblourens added this to the December 2018 milestone Nov 30, 2018

Changed access level of PatternInputWidget.inputBox to public in orde…
…r to access onDidChange event. Changed event listeners in SearchView to use onDidChange events.
@roblourens
Copy link
Member

roblourens left a comment

Thanks!

@roblourens roblourens merged commit c4cbb9f into Microsoft:master Dec 10, 2018

2 checks passed

VS Code #20181204.37 succeeded
Details
license/cla All CLA requirements met.
Details
@WinnieP

This comment has been minimized.

Copy link

WinnieP commented Feb 6, 2019

Is there a way to restore the original behavior? I keep around a list of exclusions that I sometimes swap between include/exclude (e.g. tests).

@aechan

This comment has been minimized.

Copy link
Contributor Author

aechan commented Feb 6, 2019

@WinnieP Are you saying that you'd prefer the include/exclude boxes to not clear when the clear button is pressed?

@WinnieP

This comment has been minimized.

Copy link

WinnieP commented Feb 6, 2019

@aechan Yes, I personally preferred it when those 2 boxes were not cleared when clearing results.

@aechan

This comment has been minimized.

Copy link
Contributor Author

aechan commented Feb 6, 2019

@WinnieP I would recommend opening an issue for that then.

@aechan aechan deleted the aechan:aechan/search-clear-feature branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment