New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #62365 : Added useGlobalStorageForSuggestions Setting #63193

Merged
merged 2 commits into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@skprabhanjan
Copy link
Contributor

skprabhanjan commented Nov 15, 2018

@jrieken , here is my initial implementation as per your comments to fix #62365 .
Can you please review this and suggest if anything needs to be changed or added ?
Thanks :)

@jrieken jrieken self-assigned this Nov 15, 2018

@jrieken jrieken added this to the November 2018 milestone Nov 15, 2018

@jrieken

This comment has been minimized.

Copy link
Member

jrieken commented Nov 15, 2018

Don't forget the _saveState function ;-) Then we should also think about the name of the setting

@skprabhanjan

This comment has been minimized.

Copy link
Contributor

skprabhanjan commented Nov 15, 2018

Don't forget the _saveState function ;-) Then we should also think about the name of the setting

@jrieken Oops, sorry for that, Fixed the _saveState function.
Can you please check it now and also provide the name for the setting :)
Thanks :)

@skprabhanjan

This comment has been minimized.

Copy link
Contributor

skprabhanjan commented Nov 20, 2018

@jrieken , Did you get some time to review this and also fix a name for the setting ? XD
Thanks :)

@jrieken jrieken added the suggest label Dec 3, 2018

@jrieken

This comment has been minimized.

Copy link
Member

jrieken commented Dec 3, 2018

Looking good. Thanks. I will merge and tweak the name of the setting a little.

@jrieken
Copy link
Member

jrieken left a comment

👍

@jrieken jrieken merged commit 6959ac3 into Microsoft:master Dec 3, 2018

2 checks passed

VS Code #20181115.30 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment