New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #63295: Refer to Sudo in Linux Save Error Message #63394

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@mmcru
Copy link
Contributor

mmcru commented Nov 19, 2018

This PR is meant to address #63295:

When editing a file that can't be saved without elevation, a notification pops up, prompting to try and save as administrator. On Linux, perhaps this should say "Retry with sudo"

image

I have changed the button to what @bpasero suggested in the issue ("Retry as Sudo"):

image

I look forward to any suggestions or comments, and I would be happy to change the code or error messages as necessary. This is my first attempt at a contribution, so please let me know if I am missing anything. Thanks!

@mmcru mmcru changed the title Refer to Sudo in Linux Save Error Message Fix #63295: Refer to Sudo in Linux Save Error Message Nov 19, 2018

@bpasero bpasero added this to the November 2018 milestone Nov 19, 2018

@bpasero bpasero self-assigned this Nov 19, 2018

@bpasero bpasero modified the milestones: November 2018, On Deck Nov 19, 2018

@bpasero
Copy link
Member

bpasero left a comment

@mmcru we cannot have localized messages like that with static strings, the entire string has to be a NLS string we can translate even if this means that each NLS string is duplicated for the Linux vs Windows case.

@mmcru

This comment has been minimized.

Copy link
Contributor

mmcru commented Nov 19, 2018

That makes total sense. I figured I might have something wrong with the localization. Thanks for the correction. I will fix ASAP.

@bpasero bpasero modified the milestones: On Deck, November 2018 Nov 19, 2018

@bpasero bpasero merged commit 47b3238 into Microsoft:master Nov 20, 2018

2 checks passed

VS Code #20181119.53 succeeded
Details
license/cla All CLA requirements met.
@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Nov 20, 2018

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment