Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed checkForSnapUpdate in updateService.linux.ts to correctly identify snap version #63716
This issue stems from the following discussion where it appears that the snap build of vscode by snapcrafters was throwing warnings for being outdated.
Credit to @meddario as he was able to identify exactly the failing function.
The main issue in this case is that product.applicationName is looking for the name 'code', whilst the SNAP is mounted under the name 'vscode'.
It seems that the environment variable SNAP is useful for identifying the mount point for the snap.
I have tested the backtick and functionality of the new code under a node shell.
snap connect --run vscode
The code executed as expected.
changed the title
Fixed checkForSnapUpdate in updateService.linux.ts to use environment…
Nov 25, 2018
Note that you have a potential null pointer: