New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StartupWMClass from URL handler desktop file #63750

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@davidbailey00
Copy link
Contributor

davidbailey00 commented Nov 25, 2018

Fixes #61989

See also #56727 (comment)

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 26, 2018

Awesome. Does the URL handling still work without issues?

@davidbailey00

This comment has been minimized.

Copy link
Contributor

davidbailey00 commented Nov 26, 2018

@joaomoreno Yep, works fine! I tested with the URL vscode://file/etc/hosts

@joaomoreno joaomoreno merged commit dbb3e0a into Microsoft:master Nov 28, 2018

2 checks passed

VS Code #20181125.12 succeeded
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 28, 2018

Thanks!

dcelasun added a commit to dcelasun/pkgbuilds that referenced this pull request Dec 14, 2018

dcelasun added a commit to dcelasun/pkgbuilds that referenced this pull request Dec 14, 2018

@pycontracts

This comment has been minimized.

Copy link

pycontracts commented Jan 16, 2019

Doesn't work at all, I am still getting getting the second icon on Gentoo, GNOME 3.30, and removed StartupWMClass.

@pycontracts

This comment has been minimized.

Copy link

pycontracts commented Jan 16, 2019

Update: I was able to fix the issue by actually ADDING:

StartupWMClass=code

The fix in the commit obviously is a big bummer! Please revise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment