New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added .hintrc and moved .babelrc to jsonc grammar #63759

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@donaldpipowitch
Copy link
Contributor

donaldpipowitch commented Nov 26, 2018

Hi there!

I noticed .hintrc from https://webhint.io/ isn't automatically recognized as JSON(C). Is this the correct way to add support for it?

I also moved .babelrc, because it can include comments.

@alexr00 alexr00 self-assigned this Nov 26, 2018

@alexr00

This comment has been minimized.

Copy link
Member

alexr00 commented Dec 3, 2018

Looks good, thank you for the change!

@alexr00 alexr00 self-requested a review Dec 3, 2018

@alexr00

alexr00 approved these changes Dec 3, 2018

@alexr00 alexr00 added this to the November 2018 milestone Dec 3, 2018

@alexr00 alexr00 merged commit 9289419 into Microsoft:master Dec 3, 2018

2 checks passed

VS Code #20181126.5 succeeded
Details
license/cla All CLA requirements met.

@donaldpipowitch donaldpipowitch deleted the donaldpipowitch:patch-1 branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment