New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 63749 - Markdown, U+2028, and "Go to Symbol in File..." #63936

Merged
merged 3 commits into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@skprabhanjan
Copy link
Contributor

skprabhanjan commented Nov 28, 2018

@mjbvz , Added UNICODE_NEWLINE_REGEX to replace those characters, fixes #63749 .
Please review this and let me know if any changes are needed :)
Thanks.

PS: Unit tested for many cases with those U+2028 chars and it works all fine :)

@rebornix

This comment has been minimized.

Copy link
Member

rebornix commented Nov 28, 2018

Just FYI, text buffer in VSCode/Monaco doesn't support U+2028 and U+2029 right now

@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Nov 28, 2018

@rebornix Do you recommend this workaround?

@skprabhanjan Please also add tests for this. There is skipped one already that should cover it, see 2f9f0c3

@skprabhanjan

This comment has been minimized.

Copy link
Contributor

skprabhanjan commented Nov 29, 2018

Please also add tests for this. There is skipped one already that should cover it, see 2f9f0c3

Added the test. (Removed the .skip)

pkoushik

@mjbvz mjbvz merged commit e05aa17 into Microsoft:master Nov 29, 2018

1 of 2 checks passed

VS Code in progress
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Nov 29, 2018

Thanks! The fix will be in the next VS Code insiders build and will be released with VS Code 1.30

@mjbvz mjbvz added this to the November 2018 milestone Nov 29, 2018

@skprabhanjan skprabhanjan deleted the skprabhanjan:fix-63749 branch Nov 29, 2018

@rebornix

This comment has been minimized.

Copy link
Member

rebornix commented Nov 29, 2018

@mjbvz the change for markdown is good ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment