New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #64041 - Update ParameterInformation constructor with new label type #64224

Merged
merged 2 commits into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@skprabhanjan
Copy link
Contributor

skprabhanjan commented Dec 3, 2018

@jrieken , Updated the ParameterInformation constructor which fixes #64041 .
Please review this:)

PS : This does not break anything already using this rite?
I ran the test cases and nothing failed, so assumed nothing breaks :)
Thanks :)

@jrieken jrieken self-assigned this Dec 3, 2018

@jrieken jrieken added this to the November 2018 milestone Dec 3, 2018

@KamasamaK

This comment has been minimized.

Copy link

KamasamaK commented Dec 3, 2018

This change looks good, but the @param label description should also be changed to reflect this.

pkoushik
@skprabhanjan

This comment has been minimized.

Copy link
Contributor

skprabhanjan commented Dec 3, 2018

This change looks good, but the @param label description should also be changed to reflect this.

@KamasamaK
Fixed , let me know if you think anything more needs to be changed :)

@jrieken jrieken merged commit 262b7fc into Microsoft:master Dec 3, 2018

1 of 2 checks passed

VS Code #20181203.53 failed
Details
license/cla All CLA requirements met.
@jrieken

This comment has been minimized.

Copy link
Member

jrieken commented Dec 3, 2018

Thanks

@skprabhanjan skprabhanjan deleted the skprabhanjan:fix-64041 branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment