New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #64379 - SimpleFindWidget position was changed (in hidden state) #64558

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@marchenko-am
Copy link
Contributor

marchenko-am commented Dec 6, 2018

SimpleFindWidget position was changed (in hidden state) for shadow hiding

@marchenko-am

This comment has been minimized.

Copy link
Contributor Author

marchenko-am commented Dec 6, 2018

There is a box shadow too long. I just changed position for hidden box and problem was solved.

@Tyriar

Tyriar approved these changes Dec 6, 2018

Copy link
Member

Tyriar left a comment

Looks good, I'll merge in after we branch off the upcoming release branch.

@marchenko-am

This comment has been minimized.

Copy link
Contributor Author

marchenko-am commented Dec 7, 2018

@Tyriar, ok, What do "branch off" mean?

@Tyriar

This comment has been minimized.

Copy link
Member

Tyriar commented Dec 7, 2018

@marchenko-am the release/1.30 branch was just created based off master, that's the one that will be released. Now we can merge in stuff for 1.31 🙂

@Tyriar Tyriar added this to the December 2018 milestone Dec 7, 2018

@Tyriar Tyriar merged commit 1054c55 into Microsoft:master Dec 7, 2018

2 checks passed

VS Code #20181206.44 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment