New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a terminal creation to ignore VSCode's process environment #64733

Merged
merged 3 commits into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@GabeDeBacker
Copy link
Contributor

GabeDeBacker commented Dec 10, 2018

#64731 - > Allow a terminal to be created with a specific environment by not inheriting VSCode's environment.

@Tyriar Tyriar self-assigned this Dec 10, 2018

@Tyriar Tyriar added this to the December 2018 milestone Dec 10, 2018

@Tyriar
Copy link
Member

Tyriar left a comment

@GabeDeBacker we just had the API call, the idea is approved and the final incarnation we landed on is pretty simply and much closer to the initial version:

export interface TerminalOptions {
    /**
     * Whether the terminal process environment should be exactly as provided in
     * `TerminalOptions.env`. When this is false (default), the environment will be based on the
     * window's environment and also apply configured platform settings like
     * `terminal.integrated.windows.env` on top.
     */
    strictEnv: boolean;
}

If that works for you we can keep working on the PR and merge it in.

@GabeDeBacker

This comment has been minimized.

Copy link
Contributor Author

GabeDeBacker commented Jan 9, 2019

Sorry, didn't mean to go missing in action here. I'll get on this and get it completed with the approved API design above.

@GabeDeBacker GabeDeBacker force-pushed the GabeDeBacker:user/gabrield/noInheritEnv branch from 399e115 to e1d8493 Jan 11, 2019

@Tyriar

Tyriar approved these changes Jan 11, 2019

Copy link
Member

Tyriar left a comment

LGTM, works great. Merging after CI passed 😃

@Tyriar Tyriar merged commit 3703d71 into Microsoft:master Jan 11, 2019

2 checks passed

VS Code #20190111.47 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment