New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #64253 - Support ~/ paths for typescript.tsdk #64892

Merged
merged 2 commits into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@skprabhanjan
Copy link
Contributor

skprabhanjan commented Dec 12, 2018

@mjbvz , Here is an implementation based on the inputs you gave to fix #64253 .
Please review this and let me know if anything needs to be changed :)
Thanks!

pkoushik

@mjbvz mjbvz self-assigned this Dec 12, 2018

@mjbvz
Copy link
Contributor

mjbvz left a comment

Looks good. Thanks! Just a small requested change

@mjbvz mjbvz added this to the December/January 2019 milestone Dec 14, 2018

@mjbvz mjbvz merged commit 0f5b2d1 into Microsoft:master Dec 14, 2018

2 checks passed

VS Code #20181213.16 succeeded
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Dec 14, 2018

Thanks!

@skprabhanjan skprabhanjan deleted the skprabhanjan:fix-64253 branch Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment