Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upadd .vscodeignore syntax highlighting #64960
Conversation
mjbvz
assigned
aeschli
Dec 13, 2018
aeschli
closed this
in
7c908a9
Jan 4, 2019
This comment has been minimized.
This comment has been minimized.
|
The correct place for this is extensions/extension-editing. I made the change. Still, thanks for the PR @donaldpipowitch ! |
aeschli
added this to the December/January 2019 milestone
Jan 4, 2019
This comment has been minimized.
This comment has been minimized.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
donaldpipowitch commentedDec 13, 2018
I have no idea, if this is the correct way to do it😄 I created a new extension called just
vscodeto handle VS Code specific features. I could imagine to have more VS Code specific functionality in the form of a built-in extension (e.g. also for things like.vscode/*files).I guess current VS Code specific features are currently included somewhere in the😄
src/? But I'm not sure if you want to maintain language-to-file-mappings there as well. I'm happy to move this change to a different place and to hear feedback!