New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict null checking for snippetVariables test #65236

Merged
merged 3 commits into from Dec 18, 2018

Conversation

Projects
None yet
2 participants
@usernamehw
Copy link
Contributor

usernamehw commented Dec 17, 2018

#65233

  • "./vs/editor/contrib/snippet/test/snippetSession.test.ts"
  • "./vs/editor/contrib/snippet/test/snippetVariables.test.ts"
  • "./vs/editor/contrib/snippet/test/snippetParser.test.ts"

You can see the build fail because of the src/vs/editor/contrib/snippet/snippetSession.ts strict null errors ...
I enabled only "./vs/editor/contrib/snippet/test/snippetSession.test.ts" but errors from (not a test file) appeared.

@mjbvz mjbvz merged commit ec45d20 into Microsoft:master Dec 18, 2018

1 of 2 checks passed

VS Code #20181218.2 failed
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Dec 18, 2018

Thanks. I'm going to tweak the script that generates the list of eligible files to not include files like snippetSession.test.ts which, as you saw, is not eligible yet

@usernamehw usernamehw deleted the usernamehw:strict_null_snippet_variables branch Dec 18, 2018

@mjbvz mjbvz added this to the December/January 2019 milestone Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment