New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict null checking for quickOpenScorer test #65299

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@usernamehw
Copy link
Contributor

usernamehw commented Dec 18, 2018

#65233

  • "./vs/base/parts/quickopen/test/common/quickOpenScorer.test.ts"
@bpasero
Copy link
Member

bpasero left a comment

Even though this is just a test, this hurts my eyes: void 0 as any as string.

/cc @mjbvz

@bpasero bpasero assigned mjbvz and unassigned bpasero Dec 18, 2018

@mjbvz mjbvz added this to the December/January 2019 milestone Dec 19, 2018

@mjbvz mjbvz merged commit 33ed0d8 into Microsoft:master Dec 19, 2018

1 of 2 checks passed

VS Code #20181218.52 failed
Details
license/cla All CLA requirements met.
Details

@usernamehw usernamehw deleted the usernamehw:strict_null_quickOpenScorer branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment