New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #65287 - Disable warning in markdown preview doesn't immediately hide the warning #65396

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
2 participants
@skprabhanjan
Copy link
Contributor

skprabhanjan commented Dec 19, 2018

@mjbvz , This fixes #65287
this.webviewManager.refresh(); was not there when the selection was made and it was just returning after toggling the setting value.
So I added that line before return.
Please review this and let me know if its good :)

@mjbvz mjbvz added this to the December/January 2019 milestone Dec 19, 2018

@mjbvz mjbvz merged commit 55ebf93 into Microsoft:master Dec 19, 2018

2 checks passed

VS Code #20181219.63 succeeded
Details
license/cla All CLA requirements met.
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Dec 19, 2018

Thanks! This looks like the right fix to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment