New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strictNullChecks for macLinuxKeyboardMapper #65426

Merged
merged 5 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@epicfaace
Copy link
Contributor

epicfaace commented Dec 19, 2018

As per #65233.

The change in keyboardMapperTestUtils.ts may actually fix strictNullChecks for a few other files as well.

@mjbvz mjbvz self-assigned this Dec 20, 2018

@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Dec 20, 2018

Hey looks like there's still one strict null error in that file which caused the build to fail. Some of the other merges also caused a conflict with your change

epicfaace added some commits Dec 21, 2018

@epicfaace

This comment has been minimized.

Copy link
Contributor Author

epicfaace commented Dec 21, 2018

@mjbvz, Fixed those issues. Looks like one of the CI builds is failing due to some unrelated error though... (502 bad gateway)

@mjbvz mjbvz added this to the December/January 2019 milestone Jan 3, 2019

@mjbvz mjbvz merged commit dfa7259 into Microsoft:master Jan 3, 2019

1 of 2 checks passed

VS Code in progress
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Jan 3, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment