Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable strict null check for ./vs/base/test/common/history.test.ts #65453
Conversation
gangachris
changed the title
enable strict null check
Enable strict null check for ./vs/base/test/common/history.test.ts
Dec 20, 2018
This comment has been minimized.
This comment has been minimized.
Decided to change |
alexandrudima
assigned
sandy081
Dec 20, 2018
sandy081
added this to the December/January 2019 milestone
Dec 20, 2018
sandy081
self-requested a review
Dec 20, 2018
sandy081
merged commit ce2987b
into
Microsoft:master
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
gangachris commentedDec 20, 2018
#65233
"./vs/base/test/common/history.test.ts"
Not sure how to fix this.
yarn strict-null-check
vscode/src/vs/base/test/common/history.test.ts
Lines 116 to 126 in f903e6d
result
is defined as a typestring[]
historyNavigator.current()
is defined as type<T> | null
, in this casestring | null
.I'm thinking of changing the types for
HistoryNavigator.<method>
back to just returnT
and notT | null
Thoughts ?