New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict null checking for node/flow test #65541

Merged
merged 4 commits into from Dec 21, 2018

Conversation

Projects
None yet
3 participants
@jkmdev
Copy link
Contributor

jkmdev commented Dec 21, 2018

Related to #65233

Makes it so that ./vs/base/test/node/flow.test.ts can utilize strict null checks without errors. src/vs/base/node/flow.ts was the file changed instead because the errors in the test file were related to the types in parallel's function arguments.

jkmdev added some commits Dec 21, 2018

@msftclas

This comment has been minimized.

Copy link

msftclas commented Dec 21, 2018

CLA assistant check
All CLA requirements met.

@jkmdev jkmdev changed the title Flow null check fix Enable strict null checking for node/flow test Dec 21, 2018

Revert "flow-test-fix"
This reverts commit 4f0c4be.
@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Dec 21, 2018

Looks like there are conflicts.

@bpasero bpasero added this to the December/January 2019 milestone Dec 21, 2018

@bpasero bpasero merged commit 297f871 into Microsoft:master Dec 21, 2018

2 checks passed

VS Code #20181221.41 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment